Fix audit_report: route named event types to audit_event_type#164
Open
idimov-keeper wants to merge 1 commit intoKeeper-Security:releasefrom
Open
Fix audit_report: route named event types to audit_event_type#164idimov-keeper wants to merge 1 commit intoKeeper-Security:releasefrom
idimov-keeper wants to merge 1 commit intoKeeper-Security:releasefrom
Conversation
AuditReportFilter.event_type accepts both numeric IDs and symbolic names (e.g. 'login'), but get_filter() always sent them under the 'event_type' API key. The server expects symbolic names under 'audit_event_type' and only numeric IDs under 'event_type', so name-based filters were being silently ignored. Split mixed input across both keys; preserve the existing single-value-vs-list collapsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuditReportFilter.event_typeaccepts both numeric IDs and symbolic names (e.g. 'login'), butget_filter()always sent them under the'event_type'API key. The server expects symbolic names under'audit_event_type'and only numeric IDs under'event_type', so name-based filters were being silently ignored.Split mixed input across both keys; preserve the existing single-value-vs-list collapsing.